-
Notifications
You must be signed in to change notification settings - Fork 17
Support arbitrary expressions in sum_cache and sum_through_many_cache #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeremyevans all set. lmk if you need anything else |
All reactions
Sorry, something went wrong.
This looks mostly good, thanks for the patch. However, one of the rules in Sequel development is to never attempt to parse SQL, because it's basically not possible to handle even simple cases correctly. What if summed_column is The correct way to handle this is to use I don't see any documentation updates for this. I think the documentation should probably be updated to show it is possible to use expressions in addition to columns. With those issues fixed, I'll try to test this in the next few days, and assuming no problems it will be merged and a new gem released. |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
Thanks for the quick feedback! All taken care of and documentation added. Looking forward to the new release |
All reactions
Sorry, something went wrong.
I've released 1.3.0 with this these commits. I rebased this pull request to get rid of the unnecessary merge commit, which is why this didn't get closed automatically. Thanks for your work on this! |
All reactions
-
🎉 1 reaction
Sorry, something went wrong.
Don't mention it! Thanks for shipping so quickly. Really awesome |
All reactions
Sorry, something went wrong.
Related Issue: #9
TODO:
Sequel.lit
for table names