Skip to content

Conversation

@zhou-hao
Copy link
Member

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zhou-hao
❌ fighter-wang
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the 2.3 release by adding a new metadata validation API and updating multiple components for enhanced protocol, network, gateway, and common configuration support. Key changes include:

  • Introducing a new method validateMetadata in the DDLOperations interfaces and its implementations.
  • Adding several new methods and configuration enhancements in protocol, network, gateway, and common components.
  • Updating utility classes (e.g., TopicUtils and PropertyConstants) with additional hooks and metadata constants to support the new version requirements.

Reviewed Changes

Copilot reviewed 177 out of 178 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
DDLOperations.java Added a new validateMetadata method to the interface.
ColumnModeDDLOperationsBase.java Implemented validateMetadata as a stub returning Mono.empty().
NoneThingsDataRepositoryStrategy.java Added a stub implementation of validateMetadata.
LocalProtocolSupportService.java Added deployment/un-deployment methods and error handling improvements.
ProtocolAutoConfiguration.java Added the @EnableEasyormRepository annotation.
ProtocolSupportEntity.java Extended entity functionality and introduced metadata creation for protocol definitions.
ProtocolInfo.java & ProtocolDetail.java Updated factory methods to include configuration and transport details.
NetworkConfigManager.java Introduced overloads to support selfServer parameters.
DeviceGatewayPropertiesManager.java & DeviceGatewayProperties.java Added default methods and validation annotations for gateway properties.
ElasticSearchColumnModeDDLOperations.java Updated imports to include ThingMetadata.
TopicUtils.java & Topics.java Enhanced topic building/refactoring logic with additional helper methods.
DataReferencedException.java & DataReferenceManager.java Expanded functionality for handling data reference assertions.
CommonConfiguration.java, PropertyConstants.java, ConfigMetadataConstants.java Updated configurations and constants to support version 2.3 requirements.
Files not reviewed (1)
  • jetlinks-components/common-component/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports: Language not supported

SimplePropertyMetadata.of("type", "协议类型", StringType.GLOBAL),
SimplePropertyMetadata.of("configuration", "配置", new ObjectType()),
SimplePropertyMetadata.of("describe", "说明", StringType.GLOBAL),
SimplePropertyMetadata.of("state", "状态", new EnumType()
Copy link

Copilot AI Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistency in the state metadata: while the schema for the 'state' field describes '1' as '启用', the metadata mapping assigns '1' the description '离线'. Please update the metadata to ensure consistent state descriptions.

Copilot uses AI. Check for mistakes.
fighter-wang and others added 6 commits March 31, 2025 10:22
* feat(community): 场景联动以及通知模块2.3相关功能更新

* Update pull_request.yml

* feat(community): 场景联动清除资产相关代码

* fix(场景联动): 修复场景初始化问题

* feat(community): 注册个人订阅通道

* fix(通知模块): 订阅通道初始化

* fix(通知模块): 删除无用类

* fix(community): 解决合并冲突

---------

Co-authored-by: fighter-wang <[email protected]>
Co-authored-by: 老周 <[email protected]>
* feat(community): 认证模块更新2.3相关功能

* fix(community): 修复自定义查询报错的问题

* fix(community): 优化邮件附件名称获取

---------

Co-authored-by: fighter-wang <[email protected]>
* feat(community): 补充国际化相关内容,修复设备上线/离线没有日志的问题

* feat(community): 补充设备物模型映射接口

---------

Co-authored-by: fighter-wang <[email protected]>
* fix(notify): 修复消息通知相关问题

* fix(notify): 修复订阅管理数据展示错误问题

---------

Co-authored-by: fighter-wang <[email protected]>
* fix(rule-engine): 场景联动相关bug修复

* fix(rule-engine): 场景联动相关bug修复

* fix(rule-engine): 场景联动相关bug修复

* fix(rule-engine): 修复程序启动时订阅提供商禁用,但用户已订阅仍加载成功并订阅的问题

---------

Co-authored-by: fighter-wang <[email protected]>
@zhou-hao zhou-hao requested a review from Copilot April 8, 2025 09:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 441 out of 441 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

jetlinks-components/common-component/src/main/java/org/jetlinks/community/buffer/PersistenceBuffer.java:850

  • [nitpick] The change in the default memory allocation value from 10,000 to 4096 could impact performance or memory usage; please confirm that this value change is intentional.
return 4096;

jetlinks-components/common-component/src/main/java/org/jetlinks/community/TimerSpec.java:607

  • [nitpick] Consider using a standard utility like Collections.min to retrieve the earliest time from the list, which could improve clarity and reduce manual iteration.
for (ZonedDateTime zonedDateTime : timeList) {

@zhou-hao zhou-hao merged commit 7fdfe87 into master Apr 25, 2025
1 of 2 checks passed
@zhou-hao zhou-hao deleted the refactor-2.3 branch April 25, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants