Updated default TTS Multi Voice .js file #284
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have been using the app for a while, and wanted more flexibility with my multi voice rules. As such, i choose to rewrite the default speech rules to support some more advanced features like regex matching. This allows for some complex behaviours that would take time to implement programatically, and are problems of the type that are quite prone to bugs.
I have never contributed to a project such as this, so please let me know if you'd like me to modify or otherwise extend this code.
Some possible improvments i can think of right now would be using a more extensive Regex engine which supports some useful functions like variable lookbehinds or the \K control character. I am unsure as to how exactly one would do this on an android app, but please let me know if there are some resources i can make use of to make this improvement.
Another improvement would be the addition of some sort of UI element that could allow a user to add and remove regex rules without entering the code editor. Again, same problem for me as with above.
Either way, thank you for the amazing app!