SERVER-14533 Break the foundation-lasterror-network circular dependence in build system.

The dependence was most glaringly reflected in the unittest library's dependence list,
and removing it from there required adding some missing library dependences to a few other
C++ unittests.

Author: amschwerin

src/mongo/db/repl/SConscript

@@ -12,7 +12,8 @@ env.Library(
 
 env.Library('replication_executor',
             'replication_executor.cpp',
-            LIBDEPS=['$BUILD_DIR/mongo/foundation'])
+            LIBDEPS=['$BUILD_DIR/mongo/foundation',
+                     '$BUILD_DIR/mongo/hostandport'])
 
 env.CppUnitTest('replication_executor_test',
                 'replication_executor_test.cpp',
@@ -24,15 +25,20 @@ env.Library('repl_coordinator_impl',
             LIBDEPS=['$BUILD_DIR/mongo/db/common',
                      '$BUILD_DIR/mongo/foundation',
                      '$BUILD_DIR/mongo/server_options_core',
-                     'replication_executor'])
+                     'repl_coordinator_interface',
+                     'replication_executor',
+                 ])
 
 env.CppUnitTest('repl_coordinator_impl_test',
                 'repl_coordinator_impl_test.cpp',
                 LIBDEPS=['repl_coordinator_impl',
                          'replmocks'])
 
 env.Library('repl_coordinator_interface',
-            'repl_coordinator.cpp')
+            ['repl_coordinator.cpp',],
+            LIBDEPS=[
+                '$BUILD_DIR/mongo/hostandport',
+            ])
 
 env.Library('repl_coordinator_global',
             'repl_coordinator_global.cpp',
@@ -54,6 +60,7 @@ env.Library('replica_set_config',
             ],
             LIBDEPS=[
                 '$BUILD_DIR/mongo/bson',
+                '$BUILD_DIR/mongo/hostandport',
             ])
 
 env.CppUnitTest('replica_set_config_test',

src/mongo/unittest/SConscript

@@ -2,14 +2,8 @@
 
 Import("env")
 
-# TODO(sverch): 'lasterror' should not be required by 'foundation'.  Even if it is it should be
-# depended on directly rather than here, but we currently have a triangle dependency between
-# 'network', 'foundation' and 'lasterror'.  assert_util.cpp depends on lasterror.cpp which depends
-# on sock.cpp which depends on assert_util.cpp.  Eventually we want to have an assertion library
-# that does not depend on internal server code, and then this can go away.
 env.Library("unittest", ['unittest.cpp', 'temp_dir.cpp'],
             LIBDEPS=['$BUILD_DIR/mongo/foundation',
-                     '$BUILD_DIR/mongo/lasterror',
                      '$BUILD_DIR/mongo/util/options_parser/options_parser',
             ])