Upgrade to PHP 8.3 #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 24, 2024 16:42
Upgrade to PHP 8.3
Updated the README and composer.json to require PHP 8.3 and later. Changed project author and name details in composer.json to reflect new ownership.
Introduced a new trait, DynamicPropertyTrait, to manage dynamic properties in entities. Updated DataMapper to utilize this trait for handling cases where entities have undeclared properties, and added logging for dynamic property interactions.
Removed unnecessary logging and methods related to dynamic property setting to streamline the code. Introduced a new method `instantiateClass` to handle class instantiation with necessary arguments for subclasses of `ResponseModel`.
Collaborator
|
Thank you for your contribution! While we appreciate your effort, the proposed changes don’t fully align with our requirements. Unfortunately, your solution does not address the issue of using dynamic properties in Additionally, we noticed a modification to the library’s authorship, which we believe might not be appropriate. We kindly ask you to avoid such changes in the future. The solution for handling dynamic properties has already been implemented in release v1.2.7. We value your contributions and encourage you to review the release and provide any further suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the project to PHP 8.3, ensuring compatibility with the latest PHP features, performance improvements, and security patches. Below are the major changes and considerations included in this upgrade:
Updated the syntax and refactored parts of the codebase to leverage new features in PHP 8.3 (e.g., null-safe operators, readonly properties).
Replaced deprecated functions and features with their modern alternatives.