Skip to content

Update CI #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2025
Merged

Update CI #1187

merged 7 commits into from
Jun 11, 2025

Conversation

seuros
Copy link
Contributor

@seuros seuros commented Jun 9, 2025

Those version are outdated and EOL.

For Mysql there is version 8.5 , but 8 is fine.

For postgresql, we use latest so we can try all the new features that don't exist in the past.

chore: upgrade db version from EOL
@enebo
Copy link
Member

enebo commented Jun 9, 2025

@seuros seems reasonable to me. If we find some issue with older postgresql that is still supported by 8.0 then we can either bump it back or add another service later.

@seuros
Copy link
Contributor Author

seuros commented Jun 9, 2025

I’ve gone through the PostgreSQL adapter line by line, even built extensions like PostGIS on top of it. Unless you're relying on some non-native extension, nothing breaks. It’s stable, predictable, and professionally maintained.

MySQL? Feels like a student project. They sneak in undocumented breaking changes, like in a event we had in with_advisory_lock, where version 5.7.5 silently stopped supporting nested locks without even a version bump. No heads-up, no clear fix. Just vibes.

They also randomly switched default authentication methods in some obscure release in version 8, which broke the Trilogy adapter for months, not even sure if that was fixed.

@seuros seuros force-pushed the updates branch 6 times, most recently from b7a5082 to 4c37c13 Compare June 9, 2025 22:23
@seuros
Copy link
Contributor Author

seuros commented Jun 11, 2025

@enebo :shipit:

The client had to be updated . I will remove that usage eventually later.

@enebo enebo merged commit 299f651 into jruby:master Jun 11, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants