remove anti-pattern with security issues #1188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enebo
reviewed
Jun 11, 2025
| @@ -1818,10 +1818,6 @@ protected DriverWrapper newDriverWrapper(final ThreadContext context, final Stri | |||
| catch (ClassCastException e) { | |||
| throw wrapException(context, context.runtime.getNameError(), e); | |||
| } | |||
| catch (IllegalAccessException e) { throw wrapException(context, e); } | |||
There was a problem hiding this comment.
I am not sure Java exceptions will get caught higher up in Ruby here. If so then you just crashed the Ruby process.
@kares can you review this?
There was a problem hiding this comment.
Mentioned this on matrix, just adding noise to the user due nesting real cause 2 levels deeper.
Also there aren't any security issues, it's a deprecation.
kares
reviewed
Jun 12, 2025
| private Driver allocateDriver(final Class<? extends Driver> driverClass) { | ||
| try { | ||
| return driverClass.getDeclaredConstructor().newInstance(); | ||
| } catch (InvocationTargetException e) { |
There was a problem hiding this comment.
could you please restore this do not do any exception handling an do it where it was before instead.
as explained already we do not want any extra RuntimeException or IllegalStateException wrapping...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit needs to be back-ported in all active versions.
7-2 7-1