fix: remove numeric deprecation #1193
Conversation
…precated remove warning: [deprecation] append(IRubyObject) in RubyArray has been deprecated
There was a problem hiding this comment.
@seuros you may want to let me have a shot at these deprecations. All of these changes are wrong but what you did was reasonable lacking context.
org.jruby.api package and @JRubyAPI annotations replaced the deprecated methods and methods changes to require ThreadContext was not documented as the replacement as this was changed in potentially thousands of methods. For example, getClass(String) was made into getClass(ThreadContext, String).
The obvious problem with the new API from this existing project is it pushes Ruby everywhere and not ThreadContext. As such, this will be an extremely large PR and I might be better suited to do this. Also, it may also inform additional API changes to JRuby itself. I can perhaps just change one usage and then you can see the scope of changes.
Or you can work on fixing AR failing tests for now.
|
Given your expertise with JRuby internals, it makes sense for you to handle these deprecations. I was afraid that that double work is required before and after the deprecation fix, if the interface is the same. Then i'm 🟢 to fix the Ruby part. Closing al PRs. |
depend on #1192