Patch 4

[wiese]

For the moment I only applied changes keeping original functionality, but looking forward, the token analysis also gives us a head start building a more robust way to get e.g. the data providers, maybe combined w/ 3rd party annotation parsing (doctrine/annotations).

Cheers

[jwage]

Is $classes an array? If so, change this block of code to the following:

if (!$classes) {
    return $numTestsInFile;
}

If it is not an array, keep the count and move the opening { up to the same line as the if.

[wiese]

Are you referring strictly to code style or am I missing something? Thx

[jwage]

Can you test jwage/phpchunkit-demo against this branch?

[jwage]

This will fix #9.

[jwage]

👍

[wiese]

[wiese@localhost phpchunkit-demo]$ composer.phar info jwage/phpchunkit
name     : jwage/phpchunkit
descrip. : PHPUnit Test Runner
keywords : phpunit, tests
versions : * dev-patch-4
...
[wiese@localhost phpchunkit-demo]$ docker run -v $(pwd):/app -w "/app" --rm php ./vendor/bin/phpchunkit all
PHPUnit 5.5.7 by Sebastian Bergmann and contributors.

.....                                                               5 / 5 (100%)

Time: 71 ms, Memory: 4.00MB

OK (5 tests, 5 assertions)
Total Tests: 8
Number of Chunks Configured: 14
Number of Chunks Produced: 2
Tests Per Chunk: ~1
-----------

Running chunk #1

 1/4 [🌭]  25%
 4/4 [=] 100%
Running chunk #2

 1/4 [🌭]  25%
 4/4 [=] 100%

Time: 0.12 seconds, Memory: 4MB

OK (14 chunks, 8 tests)

Seems to work

[jwage]

👍 anything else you want to take care of here or are you ready to merge?

[wiese]

No amendments in this matter. If you feel it's good, please do the honours.