This repository was archived by the owner on Apr 14, 2025. It is now read-only.
Add start of phpchunkit.xml setup. #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwage
force-pushed
the
feature/phpchunkit-xml-config
branch
3 times, most recently
from
30dd59a to
f430e2a
Compare
|
I dig the direction. Was posting my comment with the exact suggestions when the force push happened! Prefer 3 objects for listeners or defining an interface to be implemented instead and sticking them all in that one mega-listener (since they are all related in a way)? |
jwage
force-pushed
the
feature/phpchunkit-xml-config
branch
from
f430e2a to
63c647a
Compare
|
@jadb I am not sure yet. I don't like how the listeners are constructed/created right now. Other people might need more complex dependencies injected in the listeners in order to do the job. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: