Fixed and wrote documentation for Forex Demo #21
+5,488
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to ws:///jms and it could not connect, added a URI field in the actual demo and wrote the apropriate documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the forex demo, was not working because the URI would resolve to ws:///jms and it could not connect, added a URI field in the actual demo and wrote the appropriate documentation.
This problem is similar to the portfolio demo problem, this would need to be run on a Web Server to be able to resolve the the hostname correctly using
location.hostname, changed its functionality so it has a URI input field and connect/disconnect buttons, easier for users to run the demo this way.Also wrote the appropriate documentation about how to run this demo.
This is how it looks now:
