Skip to content

Conversation

edmundnoble
Copy link
Contributor

No description provided.

@edmundnoble edmundnoble requested a review from chessai September 16, 2025 18:16
@edmundnoble edmundnoble force-pushed the push-trloyuomykku branch 2 times, most recently from 6f6939f to 394e7ea Compare September 16, 2025 23:18

liftIO $ readIORef failedOnChainRef
when anyFailed $
error "some blocks failed"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe count the number of failed blocks in one chunk.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to count the total number of failures, that's a great idea.

(Codec (runPutS . encodeBlockHash) (runGetS decodeBlockHash))
["BlockHeader", cidNs, "rank"]

!db = BlockHeaderDb cid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the strictness annotation not needed anymore?

, _chainwebLogger = logger
, _chainwebPeer = peerRes
, _chainwebManager = mgr
-- , _chainwebPactData = pactData
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- , _chainwebPactData = pactData

@edmundnoble edmundnoble force-pushed the push-trloyuomykku branch 14 times, most recently from 994c512 to 760f6a0 Compare October 6, 2025 17:52
Change-Id: Id0000000fbd4c58b18ba9e4063c224da92b97b43
Change-Id: Id00000003f0e000a1190670dcce027a952183462
Change-Id: Id0000000d7901e0181766a784bb673ffabd8aa71
Change-Id: Id0000000c2ac1ace6bc1bbb8d21dfdc89e2b7ed9
Change-Id: Id0000000e02e4ac227e15f0d267484f3955af378
Otherwise the migration to BlockHistory2 happens before that table is
even created on a mainnet db. 

Ideally, we probably just delete withPactService.
Change-Id: Id000000076cfe813346a9b6fe0ae63c3237d5b03
Change-Id: Id000000074e2d41ff0d0254f3d31e9c712adc6e5
Change-Id: Id0000000255a7e431b00beb8388a10b63f4c7904
Unfortunately we write to rocksdb even when it's not necessary sometimes
as an init step. c.f. initBlockHeaderDb
Change-Id: Id00000005183459e1775505421e130ea688c3c9c
Change-Id: Id0000000b3bd3a0c6c952ae940e781b245af51d9
1. BlockHistoryMigration starts rewinding to the final block in
   BlockHistory and setting the consensus state to that block, as part
   of cleanup. (needs tests)
2. Many utilities moved from ChainwebPactDb to Backend.Utils. (these are
   not specific to PactDb though they are related to storage)
3. Stop maintaining a "latest" in ConsensusState table. This is only the
   latest row in BlockHistory table now.

Change-Id: Id00000001c55cdeb49e0280cadaf17bb040a381f
Change-Id: Id000000068eb15bd1ff51bc3590ac087c73da495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants