BlockHistoryMigration resilience to consensus out of sync with Pact #2261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1 [skip ci]
Created using jj-spr 1.3.6-beta.1 [skip ci]
larskuhtz
approved these changes
Oct 17, 2025
rsoeldner
reviewed
Oct 17, 2025
| rowBlockHash <- runGetS decodeBlockHash h | ||
| lookupRanked bhdb rowBlockHeight rowBlockHash >>= \case | ||
| Nothing -> do | ||
| -- TODO: stop when there's a missing header? |
There was a problem hiding this comment.
To my understanding this is an invariant of the system and we should fail?
There was a problem hiding this comment.
Yeah we should probably have a test for this before merge.
There was a problem hiding this comment.
I'm not sure it's worth checking now. It'd require some big changes to all of the streaming things we have here to track the current status, and all to detect a form of corruption we've never seen before to just error on it. I would rather have the Pact payload provider check on startup whether there's any corruption in this table.
rsoeldner
approved these changes
Oct 20, 2025
edmundnoble
changed the base branch from
edmundnoble/spr/evm/main.blockhistorymigration-resilience-to-consensus-out-of-sync-with-pact
to
evm/main
edmundnoble
deleted the
edmundnoble/spr/blockhistorymigration-resilience-to-consensus-out-of-sync-with-pact
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes consensus and Pact are out of sync; this is normal and
expected because catchup is not atomic w.r.t. payload providers. In
particular Pact can be ahead of consensus.
However, consensus' store of validated block headers is used to migrate
the BlockHistory table. If the corresponding headers are missing from
consensus, we can't migrate those rows of the BlockHistory table. Thus
we need to avoid erroring out in that case.
Additionally, the rows of all other Pact tables should agree with the
highest BlockHistory row. Thus we need to execute a rewind to that block
at the end of the migration.
Test Plan:
replay on mainnet database.
Change-Id: Id000000074e2d41ff0d0254f3d31e9c712adc6e5