fix: update fstproject flag syntax

[andrikaro]

root@2bd4628ac8ba:/opt/kaldi/egs/wsj/s5/utils/lang# /opt/kaldi/tools/openfst-1.8.3/bin/fstproject --help
Projects a transduction onto its input or output language.

  Usage: /opt/kaldi/tools/openfst-1.8.3/bin/fstproject [in.fst [out.fst]]

PROGRAM FLAGS:

  --project_type: type = std::string, default = "input"
  Side to project from, one of: "input", "output"

https://www.openfst.org/doxygen/fst/html/fstproject_8cc.html

I think there is a deprecated flag being used.

It seems that in some places it is up to date(on master it should be 139):

But there are 2300 with old syntax:

[jtrmal]

Thanks -- the only issue I currently don't know how to solve is that we aim to support sub 1.8 openfst too and this is breaking that. I understand now it's breaking the 1.8.x compatibility but...

[danpovey]

Yeah the new maintainers of openfst don't have a lot of respect for back compatibility it seems.
I think the right fix would be something where beforehand we figure out the correct option by giving fstproject one option and seeing how it behaves. Might be necessary to use fstcompile to give it an empty fst, and check the return status. And of course check the codebase to see where we use fstproject and do the same everywhere.

[danpovey]

Looks like you need to add back the "remove python2 installation" thing.. i thought I saw that in there beore.

[jtrmal]

yeah, I just removed it in the last commit

[stale]

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.