Pano ~ UI revamp / rebuild #13

soKaradag · 2023-07-14T11:13:55Z

No description provided.

Still not sure about using customTabbar but in TabView can't use Model Navigation. Open to suggestions for this problem.

Listing current user's posts in profile.

gunesmert · 2023-07-17T06:07:36Z

Thanks for the contribution @soKaradag ! Will have look asap.

Added Preview Toggle. User can chose is preview gonna be visible.

if user login with account shows search and profile view. If not show Login/Register view.

gunesmert · 2023-07-25T13:17:07Z

First off, great start @soKaradag!! I will be mentioning some nice to haves before having a look at the PR:

It would be nice to have a descriptive title to the PR. In our case I am switching it from Pano/Swift/SwiftUI to Pano ~ Initial UI revamp / rebuild
It would be nice to have a cool description about the content of this PR. All in all, this is your PR and you need to showcase what you have done / changed / applied to the outside world. It is really important for outsiders to see what happened on a PR without looking at the code itself. Description can contain stuff like:
- List of changes (preferably with a small explanation and link to the related issue)
- A screenshot or a video of the change
Related to ☝️ , it would be nice to see the issues updated according to the changes of this PR. I can see that our issues section is not fully organized yet but we should be able to track the progress on each of them. So, I would suggest you to update the related issues once we merge this PR with your progress.

Pano/Models/Account.swift

Pano.xcodeproj/project.xcworkspace/xcuserdata/serdar.xcuserdatad/UserInterfaceState.xcuserstate

Pano/Models/Theme.swift

Pano/Views/EntryView.swift

Pano/Views/ItemDetails/DetailsView.swift

Pano/Views/LoginRegister/Buttons/withAppleButton.swift

Pano/Views/LoginRegister/Buttons/withEmailButton.swift

Pano/Views/LoginRegister/Buttons/withGoogleButton.swift

Pano/Views/LoginRegister/Buttons/withMobileButton.swift

Pano/Views/LoginRegister/LoginRegisterView.swift

gunesmert

It looks good but I think there is some room for improvements. Added some comments and suggestions for some required changes. Let's do them before merging this PR.

In addition to that, UI looks great. Of course there are still some room for improvements but what you did is not the final implementation and things will change a lot on the go. Keep up with the good work 💪 !!

Now tabbar code more clean with enums and switch case.

Now changes on userDefaults are controlling in same place.

soKaradag

Fixed most of the problems.

soKaradag

Necessary changes have been made.

Now Tabbar enum name changed as TabType and has become more efficient.

Changed Settings view navigation to NavigationLink instead of Sheet.

soKaradag added 9 commits July 11, 2023 17:02

Add files via upload

164cd7a

Added Models and UI Changed.

c3cb47f

Added commentRow under PostDetails.

8c1bf76

Delete KampUS directory

cdb5cb8

Add files via upload

f1f940d

Add files via upload

028a572

Changed TabView with CustomTabbar.

dfc07be

Still not sure about using customTabbar but in TabView can't use Model Navigation. Open to suggestions for this problem.

Added Models and Views again.

d6ebed0

Added Profile View and more dummy data

826d193

Listing current user's posts in profile.

soKaradag added 6 commits July 18, 2023 03:00

Added preview toggle

f7eae68

Added Preview Toggle. User can chose is preview gonna be visible.

Added isUserLogin

599823a

if user login with account shows search and profile view. If not show Login/Register view.

Added settings page

a3e0160

Added Login/Register navigation view

67b1d81

Deleted Modules

479e21e

Delete PanoItem.swift

89276d9

gunesmert changed the title ~~Pano/Swift/SwiftUI~~ Pano ~ UI revamp / rebuild Jul 25, 2023

gunesmert self-assigned this Jul 25, 2023

gunesmert added the enhancement New feature or request label Jul 25, 2023