-
Notifications
You must be signed in to change notification settings - Fork 180
Improve code base with Rector #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.x
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.x #455 +/- ##
============================================
- Coverage 98.63% 98.61% -0.03%
+ Complexity 659 658 -1
============================================
Files 29 29
Lines 2056 2022 -34
============================================
- Hits 2028 1994 -34
Misses 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- StringClassNameToClassConstantRector - ClassConstantToSelfClassRector
|
while working on this I noticed that some rector rules would introduce breaking changes, because rector is not aware of a "library concept", where non-final classes could be overridden by a downstream project. My first approach was to find those specific rules and skip them. But then I had the same problem with another library. So I decided to bundle theses efforts and created a new set of backward compatible rules specific for library maintainers. (aka new side project 😊 ) |
kbsali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 awesome!!!
This PR adds rector as a new dev dependency to update the code base automatically.
Yesterday PHP 8.5 was released, so I let the tests run on PHP 8.6 (dev) as well.