Improved keyboard usability in portrait mode #972
+329
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit swaps the space and dot keys in the compact keyboard layout. The user reported that they frequently press the dot key when they intend to press the space key in portrait mode. This change addresses that issue by swapping the positions of the two keys. The following changes were made: - Modified `app/src/main/res/xml/kbd_compact.xml` to swap the keycodes and labels for the space and dot keys. - Adjusted the `keyWidth` attribute to ensure the space key retains its original width and the dot key has a standard width.
This commit swaps the space and dot keys in the compact keyboard layout. The user reported that they frequently press the dot key when they intend to press the space key in portrait mode. This change addresses that issue by swapping the positions of the two keys. The following changes were made: - Modified `app/src/main/res/xml/kbd_compact.xml` to swap the keycodes and labels for the space and dot keys. - Adjusted the `keyWidth` attribute to ensure the space key retains its original width and the dot key has a standard width.
This change swaps the dot and space keys in the portrait keyboard layout to address the issue where they were in the wrong positions.
This change swaps the dot and space keys in the following non-landscape keyboard layouts: - kbd_compact.xml - kbd_phone.xml - kbd_qwerty.xml The entire <Key> definitions have been swapped to ensure that all attributes are preserved and the layouts are not broken.
This change swaps the dot and space keys in the following non-landscape keyboard layouts: - kbd_compact.xml - kbd_phone.xml - kbd_qwerty.xml The entire <Key> definitions have been swapped to ensure that all attributes are preserved and the layouts are not broken.
This change swaps the functionality of the dot and space keys in the following non-landscape keyboard layouts: - kbd_compact.xml - kbd_phone.xml - kbd_qwerty.xml The `codes` and `keyLabel` attributes have been swapped between the keys, while the `keyWidth` and other positional attributes remain in their original places. This ensures that the large key now produces a space and the small key produces a dot.
This change reorders the dot and space keys in the following non-landscape keyboard layouts: - kbd_compact.xml - kbd_phone.xml - kbd_qwerty.xml The <Key> definitions have been reordered to ensure the dot key is small and appears before the large space key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a lot of trouble using this keyboard in portrait mode because my finger kept pressing the dot key instead of the spacebar. To solve this, I swapped the two keys to give my finger more room. After this change, the keyboard feels much more comfortable and usable. I like it so much now ! If you are not interessed drop this PR.