Skip to content

Conversation

@Vheissu
Copy link
Contributor

@Vheissu Vheissu commented Jan 21, 2025

Adds Aurelia 2 into the non-keyed frameworks list.

Adds Aurelia 2 into the non-keyed frameworks list.
Use fixed package versions
open: !process.env.CI,
port: 9000,
},
base: '/frameworks/non-keyed/aurelia2/dist/',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add this or when the built app was run, it was trying to reference the bundled assets from the root, instead of using the aurelia2/dist directory as the root.

Switched the `useDev` option to false in the Aurelia plugin configuration to ensure production settings are applied.
@krausest krausest merged commit 14849af into krausest:master Jan 26, 2025
@krausest
Copy link
Owner

Thanks. Very welcome. Turns out that aurelia2 is keyed which is really good news. I moved it to better side of the benchmark table :)
One minor issue. npm ci fails on my VPS. Any idea why?

running 'npm ci' in 'frameworks/keyed/aurelia2'
npm error code EUSAGE
npm error
npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm error
npm error Invalid: lock file's [email protected] does not satisfy [email protected]
npm error Missing: [email protected] from lock file
npm error Missing: [email protected] from lock file
npm error
npm error Clean install a project

It's not a show stopper but I don't understand why this happens. The package-lock.json stays even unchanged after running npm install. Any idea? (Node v20.17.0 on Ubuntu Linux)

@krausest
Copy link
Owner

Here are the results of a incremental run (only vanillajs, vanillajs-3, vanillajs-lite and the updated implementations. Left new keyed results, right old results - if applicable):
Screenshot 2025-01-26 at 15 13 47
Good to see aurelia is coming to the keyed camp. Performance is a bit behind react and angular though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants