-
Notifications
You must be signed in to change notification settings - Fork 44
Alternative take on an e2e conformance test view + UA filtering support in audit-log-review #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @Katharine ! Great work. I've been a bit heads down in gingko libaries, but I'd be up for a pair session in the next day or so to go through this. Ping me here or on the kubernetes slack. |
465b49b to
fc26702
Compare
|
Following on from working with @hh yesterday, I have rebased this PR to more appropriately create |
hh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this view, should should have some new data (per test User Agents) by the end of the day.
This PR, inspired by conversations with @spiffxp, explores an alternative take on viewing the e2e conformance API coverage, presenting a heatmap-style table that one can use to drill down. It also adds importing of User-Agent information from the audit log, which is used for filtering purposes, and changes the import to consider "watch" to be separate from "get".
Other changes:
python import.py <path to audit log>to do an import.inoperator to test membership of another query result ponyorm/pony#373) breaking us under some versions ofponyorm, so I have made the version constraint there more specific.This PR fairly obviously does several things. However, given the code isn't terribly large (a substantial amount of it is copying existing code from this repo) and is entirely interdependent, I'm not sure if it would be very useful to break it up further.
Here are a couple of screenshots: