Skip to content

Updated index.md to reflect changes in GEP-2162 #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Updated index.md to reflect changes in GEP-2162 #3898

wants to merge 16 commits into from
+36 −16

Conversation

bexxmodd
Copy link
Contributor

@bexxmodd bexxmodd commented Jul 3, 2025 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:

  • Added section about how conformance report will be generated based on inferring supported features from GWC.
  • Updated status to Standard.
  • Formatting fixes.

Does this PR introduce a user-facing change?:
NONE

Release Note

NONE

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Jul 3, 2025
@k8s-ci-robot k8s-ci-robot requested review from candita and kflynn July 3, 2025 01:51
@k8s-ci-robot
Copy link
Contributor

Hi @bexxmodd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2025
@bexxmodd
Copy link
Contributor Author

bexxmodd commented Jul 3, 2025

/cc @LiorLieberman

@bexxmodd bexxmodd changed the title Gep2162/index Updated index.md to reflect changes in GEP-2162 Jul 3, 2025
LiorLieberman
LiorLieberman reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bexxmodd.

I am missing the following:

  • Mesh story in all of it and future plans for mesh
  • Guidance regarding what features should be published under supportedFeatures in gateway class (only gateway features - option 1 from #3885 (comment))
  • Implications for implementations that does not implement supportedFeatures (they will not be compliant)
  • Transition period for everyone to start implement before we implement the logic to block the reports

@LiorLieberman
Copy link
Member

/cc @mlavacca @mikemorris

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2025
@bexxmodd
Copy link
Contributor Author

bexxmodd commented Jul 8, 2025

@LiorLieberman added info for all four bullet points you mentioned.

LiorLieberman
LiorLieberman approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bexxmodd

@LiorLieberman
Copy link
Member

/cc @robscott
/cc @shaneutt

@k8s-ci-robot k8s-ci-robot requested review from robscott and shaneutt July 8, 2025 16:01
robscott
robscott approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bexxmodd! Will leave final LGTM for someone else.

/approve

geps/gep-2162/index.md Outdated
## Non-Goals

* Validate correctness of supported features published by the implementation.
Meaning we don't intend to verify whether the supported features reported by
the implementation are indeed supported.

However, the supported features in the status of the GatewayClass should
make it very easy for any individual to run conformance tests against the
However, the supported features in the status of the `GatewayClass should
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you meant to have a backtick here, but if so, should have a corresponding one at the end of GatewayClass. We usually don't use backticks for resource names though, so can likely just remove this.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bexxmodd, LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

@LiorLieberman LiorLieberman LiorLieberman approved these changes

@candita candita Awaiting requested review from candita

@kflynn kflynn Awaiting requested review from kflynn

@mikemorris mikemorris Awaiting requested review from mikemorris

@mlavacca mlavacca Awaiting requested review from mlavacca

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bexxmodd @k8s-ci-robot @LiorLieberman @robscott