Skip to content

create dirs for 1.18 release #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2020
Merged

create dirs for 1.18 release #133

merged 2 commits into from
Mar 23, 2020

Conversation

kbhawkey
Copy link
Contributor

@kbhawkey kbhawkey commented Mar 3, 2020 •
edited
Loading

  • Generate directories and configuration for 1.18 release
  • Update kubectl config to generate toc (remove rolling-update)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 3, 2020
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Mar 4, 2020

/cc @tengqm

@k8s-ci-robot k8s-ci-robot requested a review from tengqm March 4, 2020 00:23
tengqm
tengqm reviewed Mar 4, 2020
View reviewed changes
gen-apidocs/config/v1_18/config.yaml
- "Coordination"
- "Core"
- "Discovery"
- "Extensions"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me that this group is dropped in 1.18?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Do you think it is a good idea to add the initial files for the release and then iterate on changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course!

@kbhawkey kbhawkey changed the title [wip] create dirs for 1.18 release create dirs for 1.18 release Mar 4, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2020
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Mar 16, 2020 •
edited
Loading

Just tried to generate all refs, testing the state of v1.18.
I grabbed a copy of swagger.json (not official 1.18 version).
The kubectl ref generated with the toc.yaml adjusted.
Attached is the error log from trying to generate the API ref.

make api
rm -rf /tmp/tmpi5d4u4dd/src/github.com/kubernetes-sigs/reference-docs/gen-apidocs/build
go run gen-apidocs/main.go --kubernetes-release=1.18 --work-dir=gen-apidocs --munge-groups=false

_Edited_
----------------------------------
Definitions with Operations Missing from Toc (Excluding old version):
[storage.v1.CSIDriver]
	 [createStorageV1CSIDriver]
	 [patchStorageV1CSIDriver]
	 [replaceStorageV1CSIDriver]
	 [deleteStorageV1CSIDriver]
	 [deleteStorageV1CollectionCSIDriver]
	 [readStorageV1CSIDriver]
	 [listStorageV1CSIDriver]
	 [watchStorageV1CSIDriver]
	 [watchStorageV1CSIDriverList]
[networking.v1beta1.IngressClass]
	 [createNetworkingV1beta1IngressClass]
	 [patchNetworkingV1beta1IngressClass]
	 [replaceNetworkingV1beta1IngressClass]
	 [deleteNetworkingV1beta1IngressClass]
	 [deleteNetworkingV1beta1CollectionIngressClass]
	 [readNetworkingV1beta1IngressClass]
	 [listNetworkingV1beta1IngressClass]
	 [watchNetworkingV1beta1IngressClass]
	 [watchNetworkingV1beta1IngressClassList]

@tengqm
Copy link
Contributor

tengqm commented Mar 17, 2020

So ... the number of newly promoted resource types is far lower than that of the deprecated ones. Good thing to know.

@kbhawkey kbhawkey mentioned this pull request Mar 21, 2020
Closed
@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2020
@kbhawkey
Copy link
Contributor Author

@tengqm , Are you around to approve? I'd like to use the "update" script to test the generation of the component tool pages and kubectl. The API ref will need the updated spec.

@tengqm
Copy link
Contributor

tengqm commented Mar 23, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel, kbhawkey, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@tengqm tengqm merged commit f1fdde9 into kubernetes-sigs:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@jimangel jimangel

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbhawkey @tengqm @jimangel @k8s-ci-robot