-
Notifications
You must be signed in to change notification settings - Fork 115
updates to build 1.20 references #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to build 1.20 references #180
Conversation
kbhawkey
commented
Dec 2, 2020
- Removed cloud-controller-manager from build target
- Created configuration for v1.19 and v1.20
- Update kubectl command toc.yaml (removed convert, added debug)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is for v1.20 @kbhawkey can you confirm that files such as gen-kubectldocs/generators/v1_19/static_includes/_app_management.md
supposed to be part of this change?
Maybe the v1.19 change could be a separate commit to make that more obvious? |
Yes, I ran the Makefile twice (1.19 and 1.20) to generate the configuration files (target createversiondirs). |
I have not looked at updating the API generator/config to address issue #178. |
There is one more error to resolve for |
/lgtm
I'll check it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |