Skip to content

updates to build 1.20 references #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

kbhawkey
Copy link
Contributor

@kbhawkey kbhawkey commented Dec 2, 2020

  • Removed cloud-controller-manager from build target
  • Created configuration for v1.19 and v1.20
  • Update kubectl command toc.yaml (removed convert, added debug)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2020
Copy link

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is for v1.20 @kbhawkey can you confirm that files such as gen-kubectldocs/generators/v1_19/static_includes/_app_management.md supposed to be part of this change?

@sftim
Copy link

sftim commented Dec 2, 2020

Maybe the v1.19 change could be a separate commit to make that more obvious?

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Dec 2, 2020

Yes, I ran the Makefile twice (1.19 and 1.20) to generate the configuration files (target createversiondirs).
The script relies upon a previous configuration to generate the next configuration and does not default to any configuration file.
The 1.19 build used the 1.18 configuration (generates dynamically in the build sandbox but does not commit).
I never got around to generating and merging a 1.19 configuration. I did this now.
The 1.20 build will use the 1.19 configuration unless there is a 1.20 configuration.
I have not read through the API configuration. The API reference will need code/config updates.

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Dec 2, 2020

I have not looked at updating the API generator/config to address issue #178.

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Dec 2, 2020

There is one more error to resolve for v1alpha1/storageversions.
/cc @tengqm

@k8s-ci-robot k8s-ci-robot requested a review from tengqm December 2, 2020 21:15
@tengqm
Copy link
Contributor

tengqm commented Dec 3, 2020

/lgtm
/approve

There is one more error to resolve for v1alpha1/storageversions.

I'll check it.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4080a75 into kubernetes-sigs:master Dec 3, 2020
@kbhawkey kbhawkey deleted the testing-1-20-build branch December 3, 2020 01:33
@tengqm
Copy link
Contributor

tengqm commented Dec 3, 2020

@kbhawkey Fix is proposed in #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants