Makefile: remove bashism #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"pushd/popd" are not part of POSIX and not supported by dash, the default shell on Debian and Ubuntu. This causes the following command to fail: $ make cli WEBROOT=/nvme/gopath/src/k8s.io/website K8SROOT=/nvme/gopath/src/k8s.io/kubernetes K8SRELEASE=1.23.0-beta.0 sudo rm -f main sudo rm -rf /nvme/gopath/src/sigs.k8s.io/reference-docs/gen-kubectldocs/generators/includes sudo rm -rf /nvme/gopath/src/sigs.k8s.io/reference-docs/gen-kubectldocs/generators/build sudo rm -rf /nvme/gopath/src/sigs.k8s.io/reference-docs/gen-kubectldocs/generators/manifest.json pushd gen-kubectldocs && go mod download && go run main.go --kubernetes-version v1_23 && popd /bin/sh: 1: pushd: not found Changing back to the original directory is unnecessary here because each make command runs in its own shell.
k8s-ci-robot
added
cncf-cla: yes
|
Thanks. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
KamilKBR
reviewed
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"pushd/popd" are not part of POSIX and not supported by dash, the default shell
on Debian and Ubuntu.
This causes the following command to fail:
Changing back to the original directory is unnecessary here because each make
command runs in its own shell.