Skip to content

gen-compdocs: update to 1.23.0 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gen-compdocs: update to 1.23.0 #259

wants to merge 1 commit into from

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Nov 18, 2021 •
edited
Loading

This is currently the latest release. Something like this PR should be needed to update https://github.com/kubernetes/website/commits/dev-1.23/content/en/docs/reference/command-line-tools-reference/

If not, feel free to close it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pohly
To complete the pull request process, please assign sftim after the PR has been reviewed.
You can assign the PR to them by writing /assign @sftim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly pohly force-pushed the gen-compdocs-deps branch from 5ad0c61 to efe8b3e Compare November 18, 2021 11:51
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2021
@pohly pohly force-pushed the gen-compdocs-deps branch from efe8b3e to f835a4b Compare November 19, 2021 07:20
@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 9, 2021

@pohly , Is it okay if we close this PR? The 1.23.0 release tag is available. Thanks.

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 9, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2021
@pohly
Copy link
Contributor Author

pohly commented Dec 9, 2021

Doesn't someone still need to update the command line tools reference for 1.23? The last update seems to be for 1.22:

https://github.com/kubernetes/website/commits/dev-1.23/content/en/docs/reference/command-line-tools-reference/kube-apiserver.md

If yes, then a PR like this will be needed.

@tengqm
Copy link
Contributor

tengqm commented Dec 9, 2021

@pohly I think @kbhawkey has already updated the build facilities for kubectl? #266

@pohly
gen-compdocs: update to 1.23.0
0532bed 
This is currently the latest release.

This update was done with a combination of
"github.com/kubernetes-csi/csi-release-tools/go-get-kubernetes.sh
1.23.0-alpha.4" invocations (didn't work right away) and some manual "go get"
calls, then later replacing with 1.23.0.
@pohly pohly force-pushed the gen-compdocs-deps branch from f835a4b to 0532bed Compare December 9, 2021 11:15
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 9, 2021
@pohly pohly changed the title gen-compdocs: update to 1.23.0-alpha.4 gen-compdocs: update to 1.23.0 Dec 9, 2021
@pohly
Copy link
Contributor Author

pohly commented Dec 9, 2021

I think @kbhawkey has already updated the build facilities for kubectl?

Yes. But isn't this directory for the other tools (kube-controller-manager, kube-proxy, etc.)?

@kbhawkey
Copy link
Contributor

I think @kbhawkey has already updated the build facilities for kubectl?

Yes. But isn't this directory for the other tools (kube-controller-manager, kube-proxy, etc.)?

Hi @pohly . Yes, PR #264 updates the go.mod and go.sum files for the gen-compdocs build. Does this make sense?

@k8s-ci-robot
Copy link
Contributor

@pohly: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2021
@pohly
Copy link
Contributor Author

pohly commented Dec 10, 2021

This PR is not needed anymore because #264 got merged instead.

/close

@k8s-ci-robot
Copy link
Contributor

@pohly: Closed this PR.

In response to this:

This PR is not needed anymore because #264 got merged instead.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Contributor

tengqm commented Dec 10, 2021

@pohly Thanks for your help anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@sftim sftim Awaiting requested review from sftim

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pohly @k8s-ci-robot @kbhawkey @tengqm