-
Notifications
You must be signed in to change notification settings - Fork 115
Initial OWNERS file #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/lgtm |
@tengqm: changing LGTM is restricted to assignees, and only kubernetes-incubator/reference-docs repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
# Reviewers can /lgtm /approve but not sufficient for auto-merge without an | ||
# approver | ||
reviewers: | ||
- Rajakavitha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use Github groups?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use aliases for groups instead of GitHub Teams, because changes to GitHub Teams are not publicly auditable.
https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#owners_aliases
That was true the time these files were initially written, github's teams have improved and that may no longer be true, we're planning to revisit that down the line
This works. /lgtm EDIT: Alas! @spiffxp 👇 |
@zacharysarah: changing LGTM is restricted to assignees, and only kubernetes-incubator/reference-docs repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm going to follow this up with a kubernetes/org issue to get everyone in this file added as a kubernetes-incubator org member |
Manually merging |
fixes #54