Skip to content

Initial OWNERS file #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Initial OWNERS file #56

merged 1 commit into from
Aug 20, 2018

Conversation

chenopis
Copy link
Contributor

fixes #54

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 13, 2018
@tengqm
Copy link
Contributor

tengqm commented Aug 14, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tengqm: changing LGTM is restricted to assignees, and only kubernetes-incubator/reference-docs repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

# Reviewers can /lgtm /approve but not sufficient for auto-merge without an
# approver
reviewers:
- Rajakavitha1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not use Github groups?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use aliases for groups instead of GitHub Teams, because changes to GitHub Teams are not publicly auditable.

https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#owners_aliases

That was true the time these files were initially written, github's teams have improved and that may no longer be true, we're planning to revisit that down the line

@zacharysarah
Copy link

zacharysarah commented Aug 20, 2018

This works.

/lgtm
/approve

EDIT: Alas! @spiffxp 👇

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: changing LGTM is restricted to assignees, and only kubernetes-incubator/reference-docs repo collaborators may be assigned issues.

In response to this:

This works.

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Aug 20, 2018

I'm going to follow this up with a kubernetes/org issue to get everyone in this file added as a kubernetes-incubator org member

@spiffxp
Copy link
Member

spiffxp commented Aug 20, 2018

Manually merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an OWNERS file
6 participants