Skip to content

Conversation

cskiwi
Copy link
Contributor

@cskiwi cskiwi commented Aug 26, 2025

Description

Hi,

I had some spare time so made some (hopefully) optimisations for the the pipeline edit screen:

  1. Loading indicator when items are still loading
  2. Remember if you check "Advanced App Configuration" for next time (I always check it, so this will save me a lot of clicks :P)
  3. Fix the environment file loader
  4. Show a dialog if you upload an env file again with overlapping keys, but changed values so you can pick and choose which you want to keep
image

I did some other async await fixes and formatting here and there because my linter was complaining about it.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Template (non-breaking change which adds a template)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I've created, editted a lot of pipelines to check if it works

  • I've built the image and tested it on a kubernetes cluster

Test Configuration:

  • Operator Version:
  • Kubernetes Version:
  • Kubero CLI Version (if applicable):

Checklist:

  • I removed unnecessary debug logs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@cskiwi
Copy link
Contributor Author

cskiwi commented Aug 26, 2025

I have no clue why that environment variable is returning true and thus giving a failed test, this shouldn't be the case :/

@mms-gianni
Copy link
Member

You even get the swiss german translations right 🤣

Love it.

@mms-gianni mms-gianni merged commit acdb574 into kubero-dev:main Sep 2, 2025
2 of 3 checks passed
@mms-gianni mms-gianni added the feature New feature or request label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants