Skip to content

Conversation

aroun-coumar
Copy link

This PR is a fix for the bug mentioned in 33080

@github-actions github-actions bot added the langchain Related to the package `langchain` label Oct 7, 2025
@aroun-coumar
Copy link
Author

@baskaryan I am not aware who maintains this repo , please add a reviewer for this fix

@eyurtsev
Copy link
Collaborator

eyurtsev commented Oct 7, 2025

@aroun-coumar you'll need to rebase against as langchain is now in langchain-classic.

We can review this PR. I think there have been previous attempts to make this fix, but those were wrong. AgentExecutor was introduced before there was a concept of a config, and I think that there was no easy way to accommodate it. We're recommending that most users change to the langchain prebuilt agent.

https://docs.langchain.com/oss/python/langchain/overview -- this is avaliable as part of the alpha release, and will be available officialy as part of the 1.0 release

…hain by adding config parameter, ensure_config, and updating docstrings (# config fix)
@aroun-coumar aroun-coumar force-pushed the feature/config-propagation-fix branch from b60ad91 to 9b6ce34 Compare October 8, 2025 11:11
@aroun-coumar
Copy link
Author

Hi @eyurtsev , I have rebased my codebase as suggested, i got few failing checks in CI which i would resolve ASAP (any support welcomed)

I locally tested my changes and now the config is passed correctly for both cases mentioned in the bug,
Please feel free to review the code.

@aroun-coumar
Copy link
Author

Since i changed the signature of _call and _acall in base.py we may have to change(add config param) all those files which uses _call and _acall in chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

langchain Related to the package `langchain`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants