clear interval when user manually closes oauth window

[pilagod]

When user closes the popup window before oauth process finishing, the time interval is still running in the background.

I add an "else if" statement to check popup window state only after the normal path, this new logic branch will not be touched if oauth finishes properly (success or failure).

[matthewmueller]

Good catch! Does it also work if it's a bit higher up?

Thinking something like this:

var intervalId = setInterval(function polling() {
  if (popup.closed) {
    clearInterval(intervalId)
    return
  }

  // ... everything else
})

[pilagod]

Yes, you're right ! I found that there are only two possible ways to close the popup:

(1) Oauth finishes
(2) Manually close

I will lift it up for better code readability 😃

[matthewmueller]

Cool – thanks bud :-)