Fix casing in directory path for Inertia components #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix intertia pages path.
Fix casing in directory path for Inertia components
pushpak1300
approved these changes
Oct 20, 2025
pushpak1300
reviewed
Oct 31, 2025
| ## Inertia Core | ||
|
|
||
| - Inertia.js components should be placed in the `resources/js/Pages` directory unless specified differently in the JS bundler (vite.config.js). | ||
| - Inertia.js components should be placed in the `resources/js/pages` directory unless specified differently in the JS bundler (vite.config.js). |
There was a problem hiding this comment.
@antojdprop thanks for the PR.
I thought about this a bit more. Hardcoding the path will break for Laravel 11 starter kits (Jetstream, Breeze, etc). Instead of doing that, can we detect the path dynamically at runtime?
For example, we could use something like:
preg_match('/[pP]ages/', $appContents, $matches);
If we detect it in any of the expected files (in priority order), we use that. If we cannot detect it, we fall back to generic wording:
"Inertia pages are stored in resources/js/ unless specified differently in the JS bundler (vite.config.js)."
That way it works across versions without assuming folder structure.
pushpak1300
requested review from
pushpak1300
and removed request for
taylorotwell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix casing in directory path for Inertia components