Sort the generated classes by name #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classes that are generated are done using symfony's finder class, which can return files in any order returned by the filesystem. This means that running the `typescript:generate` command can generate incredibly noisy diffs - whereas at least if it's sorted then the diffs should be slightly more sensible.
|
@lepikhinb any chance of getting this merged? @PatrickRose has solved an ongoing problem for our team - this minor PR mitigates noisy diffs for our services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes that are generated are done using symfony's finder class, which can return files in any order returned by the filesystem.
This means that running the
typescript:generatecommand can generate incredibly noisy diffs - whereas at least if it's sorted then the diffs should be slightly more sensible.