Adding bitcode
encoding/decoding to server fn IO
#4376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitcode
has been on the top of rust ser/de benchmarks and would be great to use withinleptos
'sserver_fn
.On the implementation-side, one question:Encodes
trait requires an error type, butbitcode
can encode anything without error. I tried to do:But am getting an error, since unit type does not impl Display. I just put a comment and made ittype Error = String
as a bandaid fix. Ideally it could be()
, or perhaps if there was some blanket struct. Unsure what is preferred?(I was told to modify the
Error
to bestd::convert::Infallible
here 4f81773 and this solves the issue above)Tested on my end, but I'd like others to confirm. I did not see any particular places to put tests for server fn IO types, otherwise I can help populate those tests