Skip to content

Conversation

@humblec
Copy link

@humblec humblec commented Nov 19, 2021

lift key protect client to latest version

This commit lift the key protect client version from

 github.com/IBM/keyprotect-go-client v0.5.1
  to
 github.com/IBM/keyprotect-go-client v0.7.0

which is the latest release available now. This PR also adjust mock tests for key protect secret test

This commit lift the key protect client version from

 github.com/IBM/keyprotect-go-client v0.5.1
  to
 github.com/IBM/keyprotect-go-client v0.7.0

which is the latest release available now.

Signed-off-by: Humble Chirammal <[email protected]>
@humblec
Copy link
Author

humblec commented Nov 19, 2021

Cc @leseb

@humblec
Copy link
Author

humblec commented Nov 19, 2021

Cc @adityadani

Copy link

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The comment in the 2nd commit does not seem really correct. I guess the secrets.mock.go was re-generated with new testify, or something. It is not only for IBM KeyProtect.

@humblec
Copy link
Author

humblec commented Nov 22, 2021

nit: The comment in the 2nd commit does not seem really correct. I guess the secrets.mock.go was re-generated with new testify, or something. It is not only for IBM KeyProtect.

Thats correct, its a general update as you mentioned @nixpanic , adjusting the commit message.

As part of the key protect client update new testify package version
also has been picked up and the mock tests have been refreshed with
the new version

Signed-off-by: Humble Chirammal <[email protected]>
@humblec
Copy link
Author

humblec commented Nov 22, 2021

nit: The comment in the 2nd commit does not seem really correct. I guess the secrets.mock.go was re-generated with new testify, or something. It is not only for IBM KeyProtect.

Thats correct, its a general update as you mentioned @nixpanic , adjusting the commit message.

Done..

@humblec
Copy link
Author

humblec commented Nov 30, 2021

@adityadani can you please take a look at this PR ? or assign this PR to the correct github id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants