Skip to content

mod+version: update lnd to v0.19.2-beta.rc2, prepare for release v0.15.1-alpha.rc1 #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

guggero
Copy link
Member

@guggero guggero commented Jul 11, 2025

We create an RC for litd to allow larger users of Lightning Terminal to upgrade to the bundled lnd v0.19.2-beta.rc2 that has important bug fixes.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @guggero, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on preparing Lightning Terminal (litd) for a new release candidate by updating its core lnd dependency to incorporate recent bug fixes. It also includes general Go module dependency updates and ensures that the application's versioning and documentation are aligned with these changes.

Highlights

  • Dependency Updates: The primary lnd dependency has been updated to v0.19.2-beta.rc2. This update is crucial as it incorporates important bug fixes from lnd.
  • Application Version Bump: The Lightning Terminal (litd) application version has been incremented to v0.15.1-alpha.rc1, signifying the preparation for a new release candidate.
  • Documentation Alignment: The README.md has been updated to reflect the new litd version and its bundled lnd daemon version, ensuring documentation consistency.
  • Go Module Dependency Refinements: Several other Go module dependencies, including lndclient, taproot-assets, lnd/sqldb, and lnd/tlv, have been updated to their latest compatible versions.
  • Release Notes Addition: A new release notes file (docs/release-notes/release-notes-0.15.1.md) has been added to document the changes for the upcoming v0.15.1 release.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares for the v0.15.1-alpha.rc1 release by updating lnd to v0.19.2-beta.rc2 and other dependencies. The changes look good overall, but I've found a few inconsistencies in the documentation (README.md and release notes) that should be corrected to avoid confusion for users. Please see my detailed comments.

Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🔥! uTACK LGTM (after the protos issue has been fixed)!

### LND

* Updated [`lnd` to
`v0.19.2-beta.rc2`](https://github.com/lightninglabs/lightning-terminal/pull/1110).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
`v0.19.2-beta.rc2`](https://github.com/lightninglabs/lightning-terminal/pull/1110).
`v0.19.2-beta.rc2`](https://github.com/lightninglabs/lightning-terminal/pull/1111).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was guessing from the existing issue/PR numbers, but got a one-off error apparently 😅

@guggero guggero force-pushed the lnd-19-2-tapd-0-6-0 branch from 60e2a96 to 70662c3 Compare July 14, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants