Change to using environment variables in favor of CLI args #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Docker images to use environment variables and add variables that guard against using a potentially volatile encryption key.
Description:
The change is to remove the CLI args:
And move them into environment variables:
This was not possible before issue #5456 but makes it more Docker-like. Note that this means the Dockerfile here will not work with builds prior to 2.0.9.103, as it requires the cmdline args.
Additionally, this PR adds the two new settings related to settings encryption described in issue #5496:
These two options and their motivation are described in #81 .
Applying these two options without the other changes is also possible and will have no effect until 2.0.9.105 is released.
Benefits of this PR and context:
This fixes #81 and makes management of Duplicati instances slightly easier.
How Has This Been Tested?
This has not been tested (not using the image myself), but replicates the Duplicati project Dockerfile.
Source / References:
Provided inline above, where relevant.