Skip to content

Wait for dc buffer status low for all published packets #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Wait for dc buffer status low for all published packets #1691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27240a3
Wait for dc buffer status low for all published packets
lukasIO Oct 14, 2025
1c2880e
remove wait from streams
lukasIO Oct 14, 2025
61b5626
Create cuddly-ties-tease.md
lukasIO Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-ties-tease.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"livekit-client": patch
---

Wait for dc buffer status low for all published packets
3 changes: 2 additions & 1 deletion src/room/RTCEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,6 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
}),
},
});

await this.sendDataPacket(packet, DataPacket_Kind.RELIABLE);
}

Expand Down Expand Up @@ -1269,6 +1268,8 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit

const msg = packet.toBinary();

await this.waitForBufferStatusLow(kind);

const dc = this.dataChannelForKind(kind);
if (dc) {
if (kind === DataPacket_Kind.RELIABLE) {
Expand Down
2 changes: 0 additions & 2 deletions src/room/data-stream/outgoing/OutgoingDataStreamManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ export default class OutgoingDataStreamManager {
// Implement the sink
async write(text) {
for (const textByteChunk of splitUtf8(text, STREAM_CHUNK_SIZE)) {
await engine.waitForBufferStatusLow(DataPacket_Kind.RELIABLE);
const chunk = new DataStream_Chunk({
content: textByteChunk,
streamId,
Expand Down Expand Up @@ -278,7 +277,6 @@ export default class OutgoingDataStreamManager {
try {
while (byteOffset < chunk.byteLength) {
const subChunk = chunk.slice(byteOffset, byteOffset + STREAM_CHUNK_SIZE);
await engine.waitForBufferStatusLow(DataPacket_Kind.RELIABLE);
const chunkPacket = new DataPacket({
destinationIdentities,
value: {
Expand Down
Loading