Skip to content

CodeGenPrepare: Null check pointers #142350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CodeGenPrepare: Null check pointers #142350

wants to merge 1 commit into from

Conversation

optimisan
Copy link
Contributor

@optimisan optimisan commented Jun 2, 2025 •
edited
Loading

Fix #142146

@optimisan Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@optimisan optimisan force-pushed the users/optimisan/06-02-codegenprepare_null_check_pointers branch from c655a6f to a313c87 Compare June 2, 2025 09:01
@optimisan optimisan marked this pull request as ready for review June 2, 2025 09:03
@optimisan optimisan requested a review from arsenm June 2, 2025 09:06
nikic
nikic reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test running CGP without PSI?

arsenm
arsenm requested changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@arsenm arsenm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be fixed with an assert. It should be a tested fatal error, and I was hoping we could do this for every pass that requires the TargetMachine

@nikic
Copy link
Contributor

nikic commented Jun 2, 2025

@arsenm I think this is fixing a different issue (and I guess shouldn't mark the other one as "fixes"). This is about the case where you do specify -mtriple but don't add require<profile-summary> to -passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

@arsenm arsenm arsenm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opt -passes=codegenprepare crashes on a null TargetMachine
3 participants
@optimisan @nikic @arsenm