Skip to content

Commit e6d0556

Browse files
committed
MAPREDUCE-3153. Fix TestFileOutputCommitter which was broken by MAPREDUCE-2702. Contributed by Mahadev Konar.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1180769 13f79535-47bb-0310-9956-ffa450edef68
1 parent 9a204fc commit e6d0556

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

hadoop-mapreduce-project/CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1549,6 +1549,9 @@ Release 0.23.0 - Unreleased
15491549
MAPREDUCE-2876. Use a different config for ContainerAllocationExpirer.
15501550
(Anupam Seth via acmurthy)
15511551

1552+
MAPREDUCE-3153. Fix TestFileOutputCommitter which was broken by
1553+
MAPREDUCE-2702. (mahadev via acmurthy)
1554+
15521555
Release 0.22.0 - Unreleased
15531556

15541557
INCOMPATIBLE CHANGES

hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/lib/output/TestFileOutputCommitter.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import org.apache.hadoop.mapreduce.task.JobContextImpl;
3838
import org.apache.hadoop.mapreduce.task.TaskAttemptContextImpl;
3939

40+
4041
public class TestFileOutputCommitter extends TestCase {
4142
private static Path outDir = new Path(System.getProperty("test.build.data",
4243
"/tmp"), "output");
@@ -187,9 +188,9 @@ public void testFailAbort() throws IOException, InterruptedException {
187188
assertNotNull(th);
188189
assertTrue(th instanceof IOException);
189190
assertTrue(th.getMessage().contains("fake delete failed"));
190-
File jobTmpDir = new File(new Path(outDir,
191-
FileOutputCommitter.TEMP_DIR_NAME).toString());
192-
File taskTmpDir = new File(jobTmpDir, "_" + taskID);
191+
String filename = committer.getTaskAttemptBaseDirName(tContext);
192+
File jobTmpDir = new File(outDir.toString(), committer.getJobAttemptBaseDirName(jContext));
193+
File taskTmpDir = new File(outDir.toString(), filename);
193194
File expectedFile = new File(taskTmpDir, partFile);
194195
assertTrue(expectedFile + " does not exists", expectedFile.exists());
195196

0 commit comments

Comments
 (0)