Escape double '??' to a literal '?' #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it possible to use literal question marks in queries to PostgreSQL. This is needed to be able to use the new JSON operators. https://www.postgresql.org/docs/9.5/static/functions-json.html This change can't break anything, since: * Anyone using double question marks would get an error if not supplied the adequate amount of accompanying values (in case of people trying the new JSON operators); or * If supplied the adequate amount of accompanying values, PostgreSQL would throw a fit because you'd supply two values directly next to each other, which doesn't make sense.
|
Anyone know how often @lpsmith checks this repository? |
|
The tests here use PSQL version 9.4 since that's when |
|
Bump. Doesn't anyone want to use JSON operators in PostgreSQL? |
|
@Vlix sorry for not noticing, I haven't watched this repository closely. If you mind making PR against my fork, it would help (there's up to date travis setup as well) |
|
@phadej Ah, hadn't noticed the maintainer has switched. Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to use literal question marks in queries to PostgreSQL. This is needed to be able to use the new JSON operators. https://www.postgresql.org/docs/9.5/static/functions-json.html
This change can't break anything, since:
Anyone using double question marks would get an error from
postgresql-simpleif not supplied the adequate amount of accompanyingActions (e.g. people trying the new JSON operators); orIf supplied the adequate amount of accompanying
Actions, PostgreSQL would throw a fit because you'd supply two values directly next to each other, which doesn't make sense.