Add some new row instances and remove some dead code. #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds few trivial instances for base's functors like Identity and Proxy. Also removes CPP conditionals for base versions < 4.6 since they're no longer supported anyways.
|
If a "cleaner" commit log is desired, I think I've got all the "remove support for old GHC" bits in my unmerged PR #228 commits. (Just a suggestion, I only care about the removal of obsolete code :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds few trivial instances for base's functors like Identity and Proxy. Also removes CPP conditionals for base versions < 4.6 since they're no longer supported anyways (according to the cabal file).