Fix spurious aborts #278
Closed
Fix spurious aborts #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for 0.6
fromJSONField: Include JSONPath on JSON parse errors
* Mention GHC generics support in documentation
No TH in implementation
This change makes it possible to use literal question marks in queries to PostgreSQL. This is needed to be able to use the new JSON operators. https://www.postgresql.org/docs/9.5/static/functions-json.html This change can't break anything, since: * Anyone using double question marks would get an error if not supplied the adequate amount of accompanying values (in case of people trying the new JSON operators); or * If supplied the adequate amount of accompanying values, PostgreSQL would throw a fit because you'd supply two values directly next to each other, which doesn't make sense.
Escape double '??' to a literal '?'
Better error message for "Query resulted in a command response"
Prepare for 0.6.1
Regenerate .travis.yml
Regenerate .travis.yml
Use MonadFail
Seems that inspection tests pass on GHC-8.8.1
Quote from the PostgreSQL documentation: > Do not include the table's name in the specification > of a target column — for example, UPDATE table_name > SET table_name.col = 1 is invalid. https://www.postgresql.org/docs/11/sql-update.html
fix UPDATE example in executeMany comment
Allow semigroups-0.19
Text taken from upstream libpq docs; this behavior is documented since libpq-8.0.
document `tableColumn` behavior on non-table columns
Allow ghc-8.8 boot libs
Updates 2019-09-19
Transactions that enter an error state must be aborted manually by issuing a "ROLLBACK". However, if the transaction error happened during a "COMMIT" then the rollback happens automatically. Issuing a "ROLLBACK" at this point causes PostgreSQL to issue a "WARNING: There is no transaction in progress". This warning can have much worse causes (e.g. you "COMMIT" but never began a transaction). This change makes the transaction retrying logic never cause PostgreSQL to issue this warning making it a more useful warning for detecting real bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.