Skip to content

Update repeater.go, fix for #16 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Update repeater.go, fix for #16 #17

merged 2 commits into from
Mar 28, 2025

Conversation

liny01-nbsa
Copy link
Contributor

I have the same issue, and my screen reader is needed for an automation tool, so I can't disable it. With this code. I have tested it works for after the change.

PS: The code is done w/ Copilot's help.

I have the same issue, and my screen reader is needed for an automation tool, so I can't disable it. With this code. I have tested it works for after the change.

PS: The code is done w/ Copilot's help.
@mame
Copy link
Owner

mame commented Mar 26, 2025

Thanks, looks good! Could you please add a test as well?

$stdout << "\xff"

It would be good enough to change "\xff" in the above line to "dummy\ndummy\ndummy\xff" or something.

@liny01-nbsa
Copy link
Contributor Author

@mame , strange enough, I had some issue running the tests locally. The last case had a few exceptions when I run on my laptop. I prepared a change as you suggested. Let me know if you'd like to make any updates. Thanks!

@mame mame merged commit 3768ffe into mame:main Mar 28, 2025
1 check passed
@mame
Copy link
Owner

mame commented Mar 28, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants