Skip to content

Optimize StructArray views #11443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Optimize StructArray views #11443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efe91f5
optimize struct array views
mourner Jan 26, 2022
ae59f92
fixup
mourner Jan 26, 2022
14d118d
revert caching vars in struct array emplace
mourner Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions build/generate-struct-arrays.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,11 @@ function createStructArrayType(name: string, layout: StructArrayLayout, includeS
const arrayClass = `${camelize(name)}Array`;

if (includeStructAccessors) {
const usedTypes = new Set(['Uint8']);
const members = normalizeMembers(layout.members, usedTypes);
const members = normalizeMembers(layout.members);
arraysWithStructAccessors.push({
arrayClass,
members,
size: layout.size,
usedTypes,
layoutClass,
includeStructAccessors
});
Expand All @@ -71,8 +69,10 @@ function createStructArrayType(name: string, layout: StructArrayLayout, includeS
}

function createStructArrayLayoutType({members, size, alignment}) {
const usedTypes = new Set(['Uint8']);
members = normalizeMembers(members, usedTypes);
const usedTypesSet = new Set();
members = normalizeMembers(members, usedTypesSet);

const usedTypes = Array.from(usedTypesSet).sort((a, b) => sizeOf(a) - sizeOf(b));

// combine consecutive 'members' with same underlying type, summing their
// component counts
Expand Down
Loading