Skip to content

Conversation

@acalcutt
Copy link
Contributor

@acalcutt acalcutt commented Apr 11, 2024

This is a merge of #649 #711 and #709 as requested by #649 (comment)

This PR updates node-pre-gyp to support up to Node 21.
1.) I updated abi_crosswalk.json to include node 21 with 'npm run update-crosswalk'
2.) It adds test coverage for cases of unsupported/unknown targets from #649
3.) It adds building with msvs 2022 and get AppVeyor to pass, from #709

Known Issues
Some tests are failing in node 20 and 21 for what look like minor line ending issues or slight path differences (which seem like differences in the responses from the node versions used more than a real issue with node-pre-gyp)

Testing
I have been using an updated abi_crosswalk.json in @acalcutt/node-pre-gyp and have used it with maplibre-native package up to node 20 (not to 21 only because we are only supporting lts releases)

Note from my own fork testing
Do not publish this from windows, it messes up the line endings in abi_crosswalk.json and makes the package fail on linux.

@acalcutt
Copy link
Contributor Author

acalcutt commented Apr 11, 2024

Does anyone ( @cclauss ) have any ideas for the node 20 appveyor errors? node 18 seems to run fine but node 20 gets some tests failures that look like possible line endings (\n) issues

acalcutt and others added 2 commits April 11, 2024 19:18
fix github warning error
Co-authored-by: Christian Clauss <[email protected]>
@cclauss
Copy link
Collaborator

cclauss commented Apr 11, 2024

Failing tests are an extra \n at the end.

test(app.name + ' configures with unparsed options ' + app.args, (t) => {

function configure(gyp, argv, callback) {

@acalcutt
Copy link
Contributor Author

acalcutt commented Apr 12, 2024

Failing tests are an extra \n at the end.

an extra "\n" where though

matrix: # https://github.com/nodejs/release#release-schedule
- nodejs_version: 16
- nodejs_version: 18
- nodejs_version: 20
Copy link
Contributor Author

@acalcutt acalcutt Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change, but i'm not sure it is corrent since it seemed only lts releases were listed here before

Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
@acalcutt acalcutt changed the title Update for node Node 21 Update for node Node 21, update AppVeyor and tests Apr 19, 2024
"node_abi": 72,
"v8": "7.8"
},
"12.22.8": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since #711 was merged, I guess you could rebase against master and drop this file from the PR

@cclauss cclauss changed the title Update for node Node 21, update AppVeyor and tests Update for node Node 22, update AppVeyor and tests Jun 29, 2024
@cclauss
Copy link
Collaborator

cclauss commented Jun 29, 2024

@cclauss cclauss requested review from benmccann and cclauss June 29, 2024 00:15
@acalcutt
Copy link
Contributor Author

looks like the only change left not already merged is adding node 22 to the list of node version being tested.

@cclauss cclauss merged commit 8886dc1 into mapbox:master Jun 29, 2024
@cclauss
Copy link
Collaborator

cclauss commented Jun 29, 2024

Awesome! Now we need to get the tests to pass on AppVeyor and then add some GitHub Actions tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants