Skip to content

Conversation

@marian-pritsak
Copy link
Owner

No description provided.

@marian-pritsak
Copy link
Owner Author

@kperumalbfn @condition SAI_NEXT_HOP_GROUP_ATTR_TYPE == SAI_NEXT_HOP_GROUP_TYPE_ECMP cannot be added because it's not NEXT_HOP_GROUP attribute - it's NEXT_HOP_GROUP_MEMBER attribute, so we can only put that in a comment

* @flags READ_ONLY
* @validonly SAI_NEXT_HOP_GROUP_ATTR_TYPE == SAI_NEXT_HOP_GROUP_TYPE_ECMP
*/
SAI_NEXT_HOP_GROUP_ATTR_REAL_SIZE,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add another next_hop_group type in sai_next_hop_group_type_t and keep these two attributes valid only for that type. Existing READ_ONLY attribute SAI_NEXT_HOP_GROUP_ATTR_NEXT_HOP_COUNT provides the actual next_hop count in a group.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the ECMP type is split as agreed

Signed-off-by: Marian Pritsak <[email protected]>
* @brief Object priority for enforcing the members' order.
*
* Index specifying the member's order.
* Should only be used if the type of owning group is SAI_NEXT_HOP_GROUP_TYPE_DYNAMIC_ORDERED_ECMP.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add more description how priority value should be given(low to high/ high to low) and how it get mapped in order list

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. High/Low definition does not really matter because within the same SAI implementation the ordering will stay the same, but the mapping description is provided

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marian-pritsak : let say we pass NH1 as 1, NH2 as 10 and NH3 as 7 then SAI will order them as { NHI, NH3, NH2 } or {NH2, NH3, NH1}

basically the number we pass here will form in ascending order or descending order ? I want to clarify from that perspective.

* @flags CREATE_ONLY
* @default internal
*/
SAI_NEXT_HOP_GROUP_MEMBER_ATTR_INDEX,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add min and max where min is 0 and max is SAI_NEXT_HOP_GROUP_ATTR_REAL_SIZE - 1

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants