-
Notifications
You must be signed in to change notification settings - Fork 1
Nhgm order #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Nhgm order #2
Conversation
Signed-off-by: Marian Pritsak <[email protected]>
|
@kperumalbfn |
| * @flags READ_ONLY | ||
| * @validonly SAI_NEXT_HOP_GROUP_ATTR_TYPE == SAI_NEXT_HOP_GROUP_TYPE_ECMP | ||
| */ | ||
| SAI_NEXT_HOP_GROUP_ATTR_REAL_SIZE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add another next_hop_group type in sai_next_hop_group_type_t and keep these two attributes valid only for that type. Existing READ_ONLY attribute SAI_NEXT_HOP_GROUP_ATTR_NEXT_HOP_COUNT provides the actual next_hop count in a group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the ECMP type is split as agreed
Signed-off-by: Marian Pritsak <[email protected]>
| * @brief Object priority for enforcing the members' order. | ||
| * | ||
| * Index specifying the member's order. | ||
| * Should only be used if the type of owning group is SAI_NEXT_HOP_GROUP_TYPE_DYNAMIC_ORDERED_ECMP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add more description how priority value should be given(low to high/ high to low) and how it get mapped in order list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. High/Low definition does not really matter because within the same SAI implementation the ordering will stay the same, but the mapping description is provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marian-pritsak : let say we pass NH1 as 1, NH2 as 10 and NH3 as 7 then SAI will order them as { NHI, NH3, NH2 } or {NH2, NH3, NH1}
basically the number we pass here will form in ascending order or descending order ? I want to clarify from that perspective.
| * @flags CREATE_ONLY | ||
| * @default internal | ||
| */ | ||
| SAI_NEXT_HOP_GROUP_MEMBER_ATTR_INDEX, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add min and max where min is 0 and max is SAI_NEXT_HOP_GROUP_ATTR_REAL_SIZE - 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
868a00e to
37f21c5
Compare
Signed-off-by: Marian Pritsak <[email protected]>
37f21c5 to
41188ec
Compare
Signed-off-by: Marian Pritsak <[email protected]>
43ce8a1 to
efc6bee
Compare
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
b2cc9b7 to
363bf8f
Compare
ec74c26 to
bfe4af3
Compare
No description provided.