Integrate parts of libmav into MAVSDK and add MavlinkDirect plugin #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will support something like MavlinkPassthrough for language wrappers.
This will bring MavlinkPassthrough to the language wrappers.
This was somewhat duplicate, we can just use a subscription with empty string to get all messages.
This is nice after auto-generation where a huge diff is just noise, especially for an LLM to parse.
I don't actually like if dependency management has to be embedded within the build. Imagine if we had to put conan, vcpkg, hunter, brew, pacman, etc. you name it, all within cmake. It would be a mess. We strive for just simple plain cmake instead. The reason this is removed now is that I need to add the dependency picosha2 and I can't find it in hunter. Also, I haven't seen any signs that hunter support is actually (still) used out there in the wild. For now, let's remove it. If this is still needed, someone will complain and help add it back in.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work towards MavlinkPassthrough for language wrappers called MavlinkDirect.
The work is based on a hard fork of libmav. The fork is required because:
The MavvlinkDirect allows you to:
While this seems to be working end to end in system tests, most of the work is Claude Code generated slop, so I will have to review this properly myself.