-
Notifications
You must be signed in to change notification settings - Fork 1
📝 [#154] add options example to setup config documentation #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 [#154] add options example to setup config documentation #155
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 24 24
Lines 832 832
Branches 67 67
=======================================
Hits 776 776
Misses 40 40
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevenbal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make sure that the help texts for deprecated fields also mention what field should be used instead of it?
|
@Floris272 django-setup-configuration 0.11.0 was released yesterday, could you pick up this PR again? |
bde946b to
249206b
Compare
Added comments to the ones i know where moved to |
stevenbal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments to the ones i know where moved to options, do you know if the remaining ones also moved to that?
endpoint_configwas moved toproviders.endpoint_configoidc_token_use_basic_auth/oidc_use_nonce/oidc_nonce_sizeandoidc_state_sizewere also moved to the same keys underproviderssync_groupswas moved toitems.options.group_settings.syncdefault_groupswas moved toitems.options.group_settings.default_groups
|
@Floris272 could you make a release that includes this? |
Partially fixes #154