Skip to content

Conversation

@Floris272
Copy link
Contributor

Partially fixes #154

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (6966805) to head (285687f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files          24       24           
  Lines         832      832           
  Branches       67       67           
=======================================
  Hits          776      776           
  Misses         40       40           
  Partials       16       16           
Flag Coverage Δ
base 81.12% <0.00%> (ø)
setupconfig 93.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Floris272 Floris272 marked this pull request as ready for review October 9, 2025 08:16
@Floris272 Floris272 requested a review from stevenbal October 9, 2025 08:32
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure that the help texts for deprecated fields also mention what field should be used instead of it?

@stevenbal
Copy link
Collaborator

@Floris272 django-setup-configuration 0.11.0 was released yesterday, could you pick up this PR again?

@Floris272 Floris272 force-pushed the feature/154-add-options-example-to-setup-config-documentation branch from bde946b to 249206b Compare October 21, 2025 11:32
@Floris272
Copy link
Contributor Author

@Floris272 django-setup-configuration 0.11.0 was released yesterday, could you pick up this PR again?

Added comments to the ones i know where moved to options, do you know if the remaining ones also moved to that?

@Floris272 Floris272 requested a review from stevenbal October 21, 2025 11:35
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments to the ones i know where moved to options, do you know if the remaining ones also moved to that?

  • endpoint_config was moved to providers.endpoint_config
  • oidc_token_use_basic_auth / oidc_use_nonce / oidc_nonce_size and oidc_state_size were also moved to the same keys under providers
  • sync_groups was moved to items.options.group_settings.sync
  • default_groups was moved to items.options.group_settings.default_groups

@stevenbal stevenbal merged commit 462367a into master Oct 23, 2025
18 checks passed
@stevenbal stevenbal deleted the feature/154-add-options-example-to-setup-config-documentation branch October 23, 2025 07:36
@stevenbal
Copy link
Collaborator

@Floris272 could you make a release that includes this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup configuration: missing examples for options

4 participants