Type check the package in CI #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 93.26% 93.65% +0.38%
==========================================
Files 24 24
Lines 832 946 +114
Branches 67 85 +18
==========================================
+ Hits 776 886 +110
- Misses 40 42 +2
- Partials 16 18 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sergei-maertens
force-pushed
the
chore/type-checking-in-ci
branch
from
a6001eb to
e4a173c
Compare
Python 3.12 has much more pleasant syntax for generic type variables, and supports the type keyword for aliases.
Fixing one pyright error at a time... The protocols are replaced with abstract base classes, as that is effectively how they are used. This will also improve the type checking situation for downstream projects.
sergei-maertens
force-pushed
the
chore/type-checking-in-ci
branch
from
e4a173c to
219577e
Compare
This seems to be a problem in every package with setup-configuration support, need to do something about it in the future.
Subclassing a union type is not possible, which highlighted that the registry is generic as long as the base plugin API is implemented.
SilviaAmAm
approved these changes
Oct 23, 2025
Contributor
SilviaAmAm
left a comment
SilviaAmAm
left a comment
There was a problem hiding this comment.
Looks good! I had initially implemented it with the abstract classes, but then I had struggled with it in the backend get_or_create_user because it felt clunky.
And now it looks so natural 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.