-
Notifications
You must be signed in to change notification settings - Fork 14
✨ [maykinmedia/open-api-framework#159] add model img docs creation #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
- Coverage 82.19% 82.16% -0.04%
==========================================
Files 128 128
Lines 2410 2411 +1
Branches 196 196
==========================================
Hits 1981 1981
- Misses 387 388 +1
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5427678 to
30a326c
Compare
30a326c to
dfe6cae
Compare
docs/uml_directive/uml.py
Outdated
| from docutils.parsers.rst import Directive | ||
|
|
||
|
|
||
| class UmlImagesDirective(Directive): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimdeBeer1 would it be possible to use the updated directive in commonground-api-common here as well? Or are there some customizations needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is possible here, only thing is that i need to add the app name of objecttypes manually
8d2fa6a to
6fad304
Compare
stevenbal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a comment about excluding the Service model
… from commonground
6fad304 to
66bd933
Compare
Fixes maykinmedia/open-api-framework#159
Changes
Added functionality to create objects model img and automatically add it to the docs.
Added objecttypes manually