Skip to content

Conversation

@TimdeBeer1
Copy link
Contributor

@TimdeBeer1 TimdeBeer1 commented Aug 13, 2025

Fixes maykinmedia/open-api-framework#159

Changes

Added functionality to create objects model img and automatically add it to the docs.

Added objecttypes manually

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.16%. Comparing base (07df212) to head (66bd933).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/objects/conf/dev.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   82.19%   82.16%   -0.04%     
==========================================
  Files         128      128              
  Lines        2410     2411       +1     
  Branches      196      196              
==========================================
  Hits         1981     1981              
- Misses        387      388       +1     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TimdeBeer1 TimdeBeer1 force-pushed the feature/datamodel-image branch 15 times, most recently from 5427678 to 30a326c Compare August 14, 2025 08:53
from docutils.parsers.rst import Directive


class UmlImagesDirective(Directive):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimdeBeer1 would it be possible to use the updated directive in commonground-api-common here as well? Or are there some customizations needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is possible here, only thing is that i need to add the app name of objecttypes manually

@TimdeBeer1 TimdeBeer1 force-pushed the feature/datamodel-image branch 4 times, most recently from 8d2fa6a to 6fad304 Compare August 21, 2025 09:59
@TimdeBeer1 TimdeBeer1 requested a review from stevenbal August 21, 2025 10:07
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment about excluding the Service model

@TimdeBeer1 TimdeBeer1 force-pushed the feature/datamodel-image branch from 6fad304 to 66bd933 Compare August 21, 2025 12:02
@TimdeBeer1 TimdeBeer1 requested a review from stevenbal August 21, 2025 12:16
@TimdeBeer1 TimdeBeer1 merged commit 9cd7a1f into master Aug 21, 2025
26 checks passed
@TimdeBeer1 TimdeBeer1 deleted the feature/datamodel-image branch August 21, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create datamodel image for each component and add this to the documentation

4 participants