Added ChibiOS RTOS Global Variable, Virtual Timers and Statistics, reworked createHmlHelp and refresh #34

vrepetenko · 2023-02-28T13:51:21Z

No description provided.

…istics

haneefdm · 2023-02-28T14:27:32Z

It is not clear to me if this was handled but we expect more than one RTOS at the same time. This happens in multu-core debug where each core may be running an RTOS. So, the state info may have to be session specific. I would use the session name.

vrepetenko · 2023-02-28T14:51:04Z

It is not clear to me if this was handled but we expect more than one RTOS at the same time. This happens in multu-core debug where each core may be running an RTOS. So, the state info may have to be session specific. I would use the session name.

I think you mean this part:

            for (const rtosSession of this.sessionMap.values()) {
                promises.push(rtosSession.updateUIElementState(elementId, state));
            }

should be:

promises.push(currentSession.updateUIElementState(elementId, state));

But where currentSession can be found?

haneefdm · 2023-02-28T15:37:13Z

There is no concept of the current session. We need to pass the session-name to the new and all settings can be then stored as a combination of <session-name>-<rtos-name>-propname. So a chance would be specific to a session and its rtos.

I have to look in the code to figure out how to pass the session-name to the webview side

Also, there could be more than one session stopped. This is why there is no concept of a current session.

haneefdm · 2023-02-28T15:46:50Z

We can make each RTOS session info under a div whose element-id would be the session-name. Session names will be unique as VSCode will not allow dups (AFAIK).

So, if you extract the full path to your element, then that could be the key.

vrepetenko · 2023-02-28T16:19:48Z

We can make each RTOS session info under a div whose element-id would be the session-name. Session names will be unique as VSCode will not allow dups (AFAIK).

So, if you extract the full path to your element, then that could be the key.

Do you mean full Dom path?
Can not get what problem we are trying to solve with this path...
Now any RTOS implementation can use 'rtos-panels' or may not use it at all.
Or xRTOS extension uses the same sessions list in different VSCODE windows, so if you open two VSCODE windows and run two different debug session there will be a problem with rtos-panels change event processing?

haneefdm · 2023-02-28T19:56:39Z

Okay, not sure we are on the same wavelength here. In a multi-core setup, we can have more than one debug session going at the same time. One session can use FreeRTOS and another can use ChibiOS. We put in a whole lot of effort to make this happen in a single instance of VSCode.

https://github.com/Marus/cortex-debug/wiki/Multi-core-debugging

You can also have multiple sessions independent of the cortex-debug method in the same instance of VSCode.

And, I am not talking about two different VSCode windows. That is a completely different topic.

vrepetenko · 2023-03-01T14:38:42Z

it is clear now, thanks for explanation!
I will try to find a solution...

…views into feature/ChibiOS-Support

…ment

haneefdm · 2023-03-09T17:23:59Z

Hmmm. It appears that a build has failed. Looks like npm run compile failed. Something wrong with package.json or node_modules?

haneefdm · 2023-03-10T10:29:24Z

@PhilippHaefele when you get a chance, could you review this PR?

PhilippHaefele · 2023-03-10T12:02:34Z

tsconfig.json

        "sourceMap": true,
        "allowJs": true,
        "checkJs": false,
+        "skipLibCheck": true,


Nice one, didn't know that one

PhilippHaefele · 2023-03-10T12:11:29Z

src/rtos/rtos-chibios.ts

+                        { columnDataKey: 'counter', title: 'Iterations' },
+                        { columnDataKey: 'cumulative', title: 'Cumulative Time' } ];
+
+const traceCols = [{ columnDataKey: 'event', title: 'Event' },


Is it intended that traceCols is not used?

yes, trace code is not in use now. It takes too long to get trace data.

PhilippHaefele · 2023-03-10T12:16:07Z

src/rtos/rtos-chibios.ts

+                                                     { name: 'aria-label', value: 'Statistics' }]);
+
+        const htmlRTOSPanels = this.getHTMLPanels([{ title: 'GLOBAL' },
+                                                   { title: `THREADS


I would like to see the threads as the default (first) entry.

I think this is the first thing a user wants to see in the first place to get an overview of the OS state.

@haneefdm Any opinion regarding this?

PhilippHaefele · 2023-03-10T12:17:04Z

src/rtos/rtos-chibios.ts

@@ -1,11 +1,13 @@
 /* eslint-disable @typescript-eslint/naming-convention */
+import { breadcrumbTemplate } from '@microsoft/fast-foundation';
+import { buffer } from 'stream/consumers';


buffer and breadcrumbTemplate do not seem to be used or do i overse something?

haneefdm · 2023-03-10T14:07:54Z

I would like to see the threads as the default (first) entry.

Agree. This would be the expectation

haneefdm · 2023-03-11T05:47:00Z

I would like to make a release soon. Quite a few things are batched up. I will merge this soon. I know @PhilippHaefele is busy for a couple of days but I would like him to finish his review.

Can you all update the CHANGELOG as needed if not already done?

PhilippHaefele · 2023-03-11T06:49:23Z

Only the default view discussion is open and after that being resolved, we're good to go from my side 👍

vrepetenko · 2023-03-11T07:23:55Z

Only the default view discussion is open and after that being resolved, we're good to go from my side 👍

check this out:
1bde86c

PhilippHaefele · 2023-03-11T08:26:29Z

Ups that somehow got hidden from me in the GitHub app 😄

@haneefdm So we're good to go

vrepetenko · 2023-03-13T12:17:02Z

I would like to make a release soon. Quite a few things are batched up. I will merge this soon. I know @PhilippHaefele is busy for a couple of days but I would like him to finish his review.

Can you all update the CHANGELOG as needed if not already done?

@haneefdm, should I update CHANGELOG with new PR?

haneefdm · 2023-03-13T15:15:45Z

I already made a release over the weekend. But, sure you can edit the CHANGELOG and update what I said. Add the PR# perhaps.

It is best to update the Changelog as we submit PRs.

vrepetenko added 5 commits February 25, 2023 21:46

added htmlEscape and getHTMLDataGrid

0edb35e

reworked tryDetect and createHmlHelp, added Global Vars, VTs and Stat…

a9348dc

…istics

merged conflicts

785df2b

fixed long lines

ab8dcb8

added rtos-panels change event, added getHTMLPanels

8ea9625

haneefdm requested review from PhilippHaefele and haneefdm February 28, 2023 14:08

vrepetenko added 6 commits March 8, 2023 23:27

added debugSessionId

3e20381

Merge branch 'mcu-debug:main' into feature/ChibiOS-Support

9238e5f

Merge branch 'feature/ChibiOS-Support' of github.com:vrepetenko/rtos-…

4391d7a

…views into feature/ChibiOS-Support

fixed lint errors

949d4dd

fixed lint problems: removed unused columnKeys and fixed col id incre…

6393079

…ment

fixed lint problems

f32be89

added skipLibCheck

557d6fb

haneefdm approved these changes Mar 10, 2023

View reviewed changes

PhilippHaefele suggested changes Mar 10, 2023

View reviewed changes

removed unused import

2561f72

swapped global and threads tabs

1bde86c

PhilippHaefele approved these changes Mar 11, 2023

View reviewed changes

haneefdm merged commit 491fcb7 into mcu-debug:main Mar 11, 2023

Added ChibiOS RTOS Global Variable, Virtual Timers and Statistics, reworked createHmlHelp and refresh #34

Added ChibiOS RTOS Global Variable, Virtual Timers and Statistics, reworked createHmlHelp and refresh #34

Uh oh!

Conversation

vrepetenko commented Feb 28, 2023

Uh oh!

haneefdm commented Feb 28, 2023

Uh oh!

vrepetenko commented Feb 28, 2023

Uh oh!

haneefdm commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haneefdm commented Feb 28, 2023

Uh oh!

vrepetenko commented Feb 28, 2023

Uh oh!

haneefdm commented Feb 28, 2023

Uh oh!

vrepetenko commented Mar 1, 2023

Uh oh!

haneefdm commented Mar 9, 2023

Uh oh!

haneefdm commented Mar 10, 2023

Uh oh!

PhilippHaefele Mar 10, 2023

Choose a reason for hiding this comment

Uh oh!

PhilippHaefele Mar 10, 2023

Choose a reason for hiding this comment

Uh oh!

vrepetenko Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PhilippHaefele Mar 10, 2023

Choose a reason for hiding this comment

Uh oh!

PhilippHaefele Mar 10, 2023

Choose a reason for hiding this comment

Uh oh!

PhilippHaefele Mar 10, 2023

Choose a reason for hiding this comment

Uh oh!

vrepetenko Mar 10, 2023

Choose a reason for hiding this comment

Uh oh!

haneefdm commented Mar 10, 2023

Uh oh!

haneefdm commented Mar 11, 2023

Uh oh!

PhilippHaefele commented Mar 11, 2023

Uh oh!

vrepetenko commented Mar 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PhilippHaefele commented Mar 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vrepetenko commented Mar 13, 2023

Uh oh!

haneefdm commented Mar 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

haneefdm commented Feb 28, 2023 •

edited

Loading

vrepetenko Mar 10, 2023 •

edited

Loading

vrepetenko commented Mar 11, 2023 •

edited

Loading

PhilippHaefele commented Mar 11, 2023 •

edited

Loading