-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
fix(baseAxis): fix y-axis tick positioning (#7061) #7083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
add condition to handle vertical axes ('left' or 'right')
ensure:
- top padding remain for visual spacing
- bottom padding remove to align zero tick with chart base
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7083 +/- ##
==========================================
- Coverage 3.55% 3.55% -0.01%
==========================================
Files 473 474 +1
Lines 47481 47513 +32
Branches 730 730
==========================================
Hits 1687 1687
- Misses 45794 45826 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…l charts add isBandAxis property to BaseAxis to distinguish axis types and apply padding correctly for different axes - add isBandAxis property to BaseAxis to distinguish axis types - apply padding on both ends for band (categorical) axes - align start of linear axes with other axis and apply padding at the end
…ype adaptation fix first bar overflow when bottom axis is value axis. check if x-axis is category axis: - if yes, apply original width logic - if no, set barWidthHalf = 0 and adjust total width to fit extra half bar
📑 Summary
Add
isBandAxisproperty to BaseAxis and refine axis padding logic to handle both vertical and horizontal charts:isBandAxisResolves #7061
📏 Design Decisions
Problem: Previous
getRange()logic only considered axis position, applied padding for both ends, causing misalignment in vertical and horizontal charts.Fix:
Introduce
isBandAxisto identify band (categorical) axesApply padding differently based on axis type and orientation:
Effect:
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.